Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map filter check to !globalcheck #285

Open
zer0k-z opened this issue Mar 24, 2022 · 2 comments
Open

Add map filter check to !globalcheck #285

zer0k-z opened this issue Mar 24, 2022 · 2 comments

Comments

@zer0k-z
Copy link
Contributor

zer0k-z commented Mar 24, 2022

While it is possible to solve inside GOKZ, this should be done from GlobalAPI side. Since GlobalAPI repo has no issue page, I figure might as well put the issue here.

@zer0k-z zer0k-z changed the title Add filter check to !globalcheck Add map filter check to !globalcheck Mar 24, 2022
@walliski
Copy link
Contributor

What would the global check check on the map filters? That there exists a single filter at least for the maps main course, or?

Doesn't make much sense to have that kind of check I would say, since its not an issue with the server that filters are not there, so why check it on the server?

@zer0k-z
Copy link
Contributor Author

zer0k-z commented Aug 20, 2022

Checking the filter on the server is a good way to ensure your run does get uploaded to the API and is not wasted. Happens a lot for VNL players where they do a very hard map (previously believed to be not possible) just to realize there is no filter for the correponding courses.

That said, I realized that the combination of run types, modes and courses might make this filter check more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants