Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show market place (recommendation country) in full name instead of abbreviation #96

Closed
momobobe opened this issue Jun 2, 2022 · 3 comments
Labels
deployed This issue has been fixed/implmented and has been released enhancement New feature or request

Comments

@momobobe
Copy link

momobobe commented Jun 2, 2022

The two-letter code for country is confusing in most cases if it's not known in advance. Please use full names (commonly used ones, no intention to bother asking for official names) for better readability.

@momobobe momobobe added the enhancement New feature or request label Jun 2, 2022
@momobobe momobobe changed the title Show market place (recommadation country) in full name instead of abbreviation Show market place (recommendation country) in full name instead of abbreviation Jun 2, 2022
@KRTirtho
Copy link
Owner

KRTirtho commented Jun 2, 2022

Showing small country code is more efficient & at the same time takes less space. And it's a standard thing to use abbreviation instead of full country names around the world. But there's no rule for following those standards so there's always room for improvement. Since you're interested in full country names you can contribute to the project by writing the names

Country Codes are available at https://github.com/KRTirtho/spotube/blob/master/lib/models/SpotifyMarkets.dart You can just change those to appropriate country names & create a PR

@momobobe
Copy link
Author

momobobe commented Jun 5, 2022

#101 done

I kept the ISO codes, but now there is a problem that how to sort them. If by name, then there are certain exceptions like the Bahamas, Democratic Republic of the Congo, Republic of the Congo, the Gambia (and maybe El Salvador) that should be sorted according to a non-initial word. Also note the new order would be different from the previous one by ISO code, so to sort them in the new way, maybe you need to write something to map them.

@momobobe
Copy link
Author

momobobe commented Jun 5, 2022

BTW, I'm not sure, but it seems https://support.spotify.com/us/article/where-spotify-is-available/ lists some more countries (such as non-state countries), how do you think?

@KRTirtho KRTirtho added the deployed This issue has been fixed/implmented and has been released label Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed This issue has been fixed/implmented and has been released enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants