Skip to content

Wrong Song Playing #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
clubberduck opened this issue Sep 19, 2023 · 7 comments
Closed
1 task done

Wrong Song Playing #737

clubberduck opened this issue Sep 19, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@clubberduck
Copy link

clubberduck commented Sep 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

For example, I want to listen to Amon Amarth's 7th song from their first album, Once Sent From The Golden Hall. I press the button for the song 'Amon Amarth', and I get 'Heidrun' instead. I understand that the songs playing get searched on youtube, but my recommendation would be to search the name of the song, then artist, then album, kinda like:
%song name% %album name% %artist name%, instead of %song name% like it seems to be right now.
For a sillier example, on the bonus edition of the same album, there is a live version simply titled 'Amon Amarth (Live)'.
The result, a 50-minute concert that begins with the end of Iron Maiden's 'Run To The Hills'.
image

Expected Behavior

When I click on Amon Amarth I want Amon Amarth, not Heidrun or Guardians Of Asgaard

Steps to reproduce

  1. Open Spotube
  2. Enter the album page of "Once Sent From The Golden Hall" by using the search function.
  3. Press either "Amon Amarth" or "Amon Amarth (Live)"

Operating System

Android, Linux

Spotube version

v3.1.2 on linux, v3.1.1 on android

Installation source

Website (spotube.netlify.app) or (spotube.krtirtho.dev), F-Droid (Android)

Additional information

I really hope this can be fixed, as the app itself is wonderful, and miles better at not consuming battery than regular spotify.
I have also tested it with 'In Flames'. Their song named after the band also has the same issue. It plays 'Meet Your Maker'

@clubberduck clubberduck added the bug Something isn't working label Sep 19, 2023
@KRTirtho
Copy link
Owner

KRTirtho commented Sep 19, 2023

. I understand that the songs playing get searched on youtube, but my recommendation would be to search the name of the song, then artist, then album, kinda like:
%song name% %album name% %artist name%, instead of %song name% like it seems to be right now.

Nope it's already using <cleaned Song Name> - <all artist name separated by comma>

But the problem with Amon Amarth is while cleaning the title Spotube removes any artist's name from the title to avoid duplication of Artist's name. That's why the entire track name is getting removed

  • Looks like we've to make sure to check if title is not empty string after cleaning
    • If it's empty "" don't clean the title

@KRTirtho KRTirtho moved this to Discussion in Spotube Board Sep 19, 2023
@clubberduck
Copy link
Author

Thanks man, I can't wait to see this fixed!

@clubberduck
Copy link
Author

And by the way, why does any list start with 0?

@github-project-automation github-project-automation bot moved this from Discussion to Done in Spotube Board Sep 19, 2023
@clubberduck clubberduck reopened this Sep 19, 2023
@github-project-automation github-project-automation bot moved this from Done to In progress in Spotube Board Sep 19, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Spotube Board Sep 19, 2023
@KRTirtho KRTirtho reopened this Sep 19, 2023
@github-project-automation github-project-automation bot moved this from Done to In progress in Spotube Board Sep 19, 2023
@KRTirtho
Copy link
Owner

It's not yet fixed so why closed it?

@clubberduck
Copy link
Author

Well I thought the discussion was over, so I assumed I should close it

@clubberduck
Copy link
Author

I just realized what alternate sources does... I feel I should just post here that this can be fixed on a song by song basis with alternate sources.

@MatteoDelOmbra
Copy link

MatteoDelOmbra commented Oct 9, 2023

Another example of that bug (may be useful during testing) is almost whole album https://open.spotify.com/album/2ItrzcwLrygr4I6wlZ3HGU
My guess it that problem occurs when "#" char or any polish letter (ż,ó,ł,ć,ę,ś,ą,ź,ń) is used, because problem exists only in such tracks here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Deployed
Development

No branches or pull requests

3 participants