Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download lyrics along with track doesn't work #479

Closed
1 task done
Turhvjbufv opened this issue Apr 15, 2023 · 5 comments
Closed
1 task done

Download lyrics along with track doesn't work #479

Turhvjbufv opened this issue Apr 15, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Turhvjbufv
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Should download the track and .lrc file with synced lyrics

Expected Behavior

Only downloads the track

Steps to reproduce

Open the app choose a random song and download it

Operating System

Android

Spotube version

2.7.1

Installation source

GitHub Releases (Binary)

Additional information

No response

@Turhvjbufv Turhvjbufv added the bug Something isn't working label Apr 15, 2023
@KRTirtho
Copy link
Owner

This feature is incomplete as downloading lyrics as txt file is completely useless since you can't even use it. We're are now planning on embedding lyrics in the mp4 metadata which is supported by many players and media servers

@Turhvjbufv Turhvjbufv closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
@ThreeDeeJay
Copy link

There are tons of players (including Android) that support .LRC (scrolling lyrics) format, though.
Would be nice to download even lyrics alone for existing files that other lyrics sources don't yet have an LRC file for.

@ThreeDeeJay
Copy link

@KRTirtho Do Spotify/Spotube already use LRC for scrolling lyrics? Cuz I just noticed this line

Uri.parse("$baseUri/${topResult.attributes["href"]}&type=lrc");

If so, I think all we'd need is for the LRC to be copied next to the track file with the same file name for other apps to load it

@ThreeDeeJay
Copy link

In case anyone cares, just found out about this https://github.com/Lambada10/SongSync

@Turhvjbufv
Copy link
Author

Yeah it's very bice

@ThreeDeeJay ThreeDeeJay mentioned this issue Sep 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants