Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Google Lyrics as default lyrics provider #421

Closed
1 task done
ghost opened this issue Feb 26, 2023 · 6 comments
Closed
1 task done

[Feature] Support Google Lyrics as default lyrics provider #421

ghost opened this issue Feb 26, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request invalid/out-of-scope This doesn't seem right (or out of scope)

Comments

@ghost
Copy link

ghost commented Feb 26, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Category of the Feature

UI Improvements, More Efficiency

Credits

Pain

Currently Spotube lyrics system on Android is not good.

There are two options: "Synced" and "Genius"

99% of the times "Synced" doesn't load any lyrics, while "Genius" loads lyrics mostly in English, but local songs from other languages from other countries are often not in Genius' database, and it takes time to load .

Suggested Solution

I've been studying the eSound Music app that's on the PlayStore: https://play.google.com/store/apps/details?id=com.esound

I noticed that it uses a very simple, but at the same time effective system to load song lyrics: Google Search

Through eSound Webplayer analysis (https://esound.app), I noticed that while brazilian Cazuza's "Exagerado" music was playing, the desktop browser makes a request to the Google.com website: Access to XMLHttpRequest at 'https://www.google.com/search?q=Cazuza%20exagerado%20lyrics&oq=Cazuza%20exagerado%20lyrics&sourceid=chrome&ie=UTF-8&lr=lang_en'

Basically, the user desktop browser searches for "Cazuza exagerado lyrics" or, for example, "Avicii the nights lyrics" on google.com

So if Spotube makes a command for the user's device to load the term: Singer name + song name + word "lyrics" in Google.com website the chance of finding the lyrics of the songs is much greater, at the same time that the loading is extremely fast, precisely because of Google's infrastructure around the world.

Even putting a singer from another country, like the name of his song that is in another language (brazilian portuguese, for example) and then the term "lyrics", Google.com is still able to find the lyrics of the song in the original language that is sung.

This could be implemented on all platforms currently supported by Spotube such as Android, Linux,
Windows and Mac.

Useful resources/references

No response

@ghost ghost added enhancement New feature or request good first issue labels Feb 26, 2023
@ghost ghost assigned KRTirtho Feb 26, 2023
@KRTirtho
Copy link
Owner

KRTirtho commented Mar 8, 2023

@jakecharlie no more worries. Spotube now uses Official Spotify Lyrics (Musixmatch) so all your issues should be resolved
Try the 2.7.0 and let me know

@KRTirtho KRTirtho moved this to Discussion in Spotube Board Mar 8, 2023
@KRTirtho KRTirtho added the invalid/out-of-scope This doesn't seem right (or out of scope) label Mar 8, 2023
@RaptaG
Copy link
Contributor

RaptaG commented Mar 8, 2023

Closing because of the new, accurate official lyric support

@RaptaG RaptaG closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from Discussion to Done in Spotube Board Mar 8, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Mar 8, 2023
@ghost
Copy link
Author

ghost commented Mar 8, 2023

@KRTirtho @RaptaG

Thank you, I will test it. I use F-droid apk store. A curiosity: Why is the new apk in F-droid not updated as quickly as it is here on github (there it continues with version 2.6.0)? And is there any prediction of when version 2.7.0 will appear there?

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 9, 2023

There's some difficulty going on with f-droid. Don't worry we'll update it as soon as possible

@ghost
Copy link
Author

ghost commented Mar 9, 2023

@KRTirtho Is there any spotube external repository that I can manually add in the fdroid app so that the user can get updates faster? Maybe izzyondroid or maybe a spotube specific link.

Thank you

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 9, 2023

F-droid isn't delaying the build. There were some build configs I didn't update before hand :p

@KRTirtho KRTirtho moved this from Deployed to Won't be possible in Spotube Board Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid/out-of-scope This doesn't seem right (or out of scope)
Projects
Status: Won't be possible
Development

No branches or pull requests

2 participants