Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] This app is broken... #400

Open
1 task done
Rstment25 opened this issue Feb 3, 2023 · 15 comments
Open
1 task done

[Bug] This app is broken... #400

Rstment25 opened this issue Feb 3, 2023 · 15 comments
Assignees
Labels
bug Something isn't working UI A suggestion/bug report of a UI element

Comments

@Rstment25
Copy link

Rstment25 commented Feb 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I love the app but it's getting ridiculous... So much trouble with the playback that it's not enjoyable at all

Playlist stalls when it encounters a song it can't play... Infinite loading...
Screenshot_20230203-131941_Spotube

Some songs play successfully but then the song after doesn't play for some reason? ( Like whatever song you place after them will not play ... )

*When I hit play next song it duplicates the song that's currently playing... It hangs on the infinite loading bug , when you check music queue you can see the duplicate:
Screenshot_20230203-131938_Spotube

Some songs have the first 10-30 seconds cut off entirely ( I am not sure if sponsor block is malfunctioning and doing unnecessary cutting... I disabled it so will see if it happens again... )

There are also instances where the playback glitches , it gets stuck on certain second of a song and like a broken record keeps repeating that one second of a song - back and forward.... Usually it's the last 10s of a song or first 10s of next song where it gets stuck ( And only on certain songs )

  • I believe this is from a bad implantation of time seek bar ... It coincides with notifications showing wrong time of the song ( Can't show right now , will try to screenrecord )

It is forcing me to remove songs from my playlist...

When playlist cannot proceed I have to manually create a personal playlist and remove all the songs which don't work ( Just creating a new playlist sometimes fixes problematic songs... I guess there's also some API issues with your implementation... Check screenshot below )

I can't use the app ATM
Screenshot_20230203-132435_Spotube

I guess there's some downtime on Spotify APIs? Idk... I hope in few hours it gets back up again

I'd send more screenshots but I can't play anything other than the song queue I had from before... And even that as you can see is broken xd

If you wanna debug these feel free to reach out...

I can send adb logs (adb logcat | grep "?")

Also check out this playlist:
https://open.spotify.com/playlist/3rntZpf4ewfbn6mg5XUMOa

When you add it to your spotify ( just click like on playlist ) and try playing it via spotube it only plays the first song - click next and the second song won't play.
If you can get the same behaviour on your device it should help you with debugging I guess ? ( I can also help on my end , just instruct me on what you need ... Either here or I can add you on some other platf )

Expected Behavior

.

Steps To Reproduce

No response

Spotube Version

2.6.0

Operating System

Android

Linux Distribution (if applicable)

No response

Operating System Version

Android 12.

Installation Source

F-Droid (Android)

Additional information

No response

@Rstment25 Rstment25 added bug Something isn't working good first issue labels Feb 3, 2023
@Rstment25
Copy link
Author

Rstment25 commented Feb 3, 2023

Here's an example of how I fixed the issue above...

Screenshot_20230203-140733_Spotube

*Removing the "left behinds" song number 4 allows it to play without hanging...
Screenshot_20230203-140849_Spotube

*Also take a look at this picture - I clicked on play , and before it fully loaded and started playing the first song I clicked on the "go next" button which broke the player... It duplicated the second song and now it will only play that song, when the player reaches the end it stops playing, it doesn't go next - buttons forward/backward also don't work

Screenshot_20230203-140807_Spotube

@KRTirtho
Copy link
Owner

KRTirtho commented Feb 4, 2023

I was actually working on these horrendous bugs. PR #399 hopefully fixed a lot of these issues. Most of them were occurring because of data races and mutable state
Luckily, I was able to identify those bugs. But fixing those would've been a nightmare, so I re-wrote the entire playback implementation based on immutable state which additionally enabled queue support

It should be available via nightly by now. Please check the v2.6.0-nightly-87 (latest) to see if you're still facing those issues

@Rstment25
Copy link
Author

I was actually working on these horrendous bugs. PR #399 hopefully fixed a lot of these issues. Most of them were occurring because of data races and mutable state Luckily, I was able to identify those bugs. But fixing those would've been a nightmare, so I re-wrote the entire playback implementation based on immutable state which additionally enabled queue support

It should be available via nightly by now. Please check the v2.6.0-nightly-87 (latest) to see if you're still facing those issues

oof , is working much better but still not quite bug free x:

Player is much more responsive , on that end I'm pretty satisfied so far. What's not working is everything else xd

*black filter... I didn't see it's on
Anyways as soon as I opened the app I got this ( Not signed in yet , restarting app fixed it )
Screenshot_20230204-200545_Spotube

*After signin the playlist did not update , had to do another restart - that's 2 restarts already to get the app working

Anyways , some songs still don't play - they never load up and player gets stuck waiting... ( This could be a Spotify API issue ? Like it's not getting song data ? Or is it something else... )

This is the song
Screenshot_20230204-200738_Spotube

*I tried searching for it in the search menu which brought another bug
Screenshot_20230204-200907_Spotube
*As you can see it loads the list of songs but then few seconds later it grays out and stays like that
Screenshot_20230204-200828_Spotube

*Had to restart the app , that's 3 restarts already xd

Only to find out , that while search now works I can't really get it to play any of the songs ... Clicking on them does nothing , it doesn't play, doesn't open the player , just nothing

@Rstment25
Copy link
Author

@KRTirtho anyways thanks for all the work, I'll just ignore this song in particular and hope the rest of them work better now 🫣

@Rstment25
Copy link
Author

Rstment25 commented Feb 4, 2023

Wait.... I'm on nightly 2-6.0 (84)

Where do I get nightly 87? ( I did click on nightly link and download from there already )

*I found couple more bugs but I'll wait till nightly 87 shows up for download

I was actually working on these horrendous bugs. PR #399 hopefully fixed a lot of these issues. Most of them were occurring because of data races and mutable state Luckily, I was able to identify those bugs. But fixing those would've been a nightmare, so I re-wrote the entire playback implementation based on immutable state which additionally enabled queue support

It should be available via nightly by now. Please check the v2.6.0-nightly-87 (latest) to see if you're still facing those issues

@KRTirtho
Copy link
Owner

KRTirtho commented Feb 5, 2023

well v2.6.0-nightly-88 is up

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 8, 2023

@Rstment25 Can you check with v2.7.0 and provide me a list of what's fixed or broken from issues you encountered?

@RaptaG RaptaG added UI A suggestion/bug report of a UI element and removed good first issue labels Mar 8, 2023
@Rstment25
Copy link
Author

@Rstment25 Can you check with v2.7.0 and provide me a list of what's fixed or broken from issues you encountered?

Soreh , kinda busy rn... Haven't used the app since

I'll try whenever I have some free time

@moussetc
Copy link

Hi!
I've just installed the Android app for the first time (2.7.1 build 18), logged in to my non-premium Spotify account and I cant get songs to play reliably, as described in this Issue. The best I for was 10s or so seconds of the first song I tried, but that only got played several minutes later as I was clicking ln the play button for others songs, while trying to get at least one working.

@szotsaki
Copy link

  • I can confirm. Unfortunately, the gaps between song plays are still there.
  • Play status indicators in the playlist and in the bottom bar are inconsistent (one is showing the actual song is playing, the other one that it's paused).
  • When you click on a track to play, it starts loading for 10 seconds, then nothing happens.

@KRTirtho
Copy link
Owner

KRTirtho commented May 6, 2023

In the latest nightly the old android.MediaPlayer based audioplayers plugin is replaced with android.media3.ExoPlayer based just_audio which significantly decreases the loading time. And now it adds the ability to even show buffered duration
So please try out the nightly apk to check if it's working for you too

@KRTirtho
Copy link
Owner

KRTirtho commented May 6, 2023

Some parts maybe broken especially the notification control and local tracks but it'll be fixed eventually

@moussetc
Copy link

moussetc commented May 9, 2023

In the latest nightly the old android.MediaPlayer based audioplayers plugin is replaced with android.media3.ExoPlayer based just_audio which significantly decreases the loading time. And now it adds the ability to even show buffered duration So please try out the nightly apk to check if it's working for you too

Hi, thanks. I have tried the nightly and the results have been ambivalent: one playlist ran okay, but on other days, I have had issues again, with most of playlist songs not playing

Even with the playlist that was played more or less correctly, the less, I think, comes from having huge gap between songs. Is there no preloading of the next song? Or is the download time just so very slow (note: I did not have trouble with Youtube so I wouldn't only blame the network on my side), occasionally even worse so that a whole playlist won't load?

Tell you what, if there are logs on the app, do tell me where to get them so I can post them here if that would help troubleshooting :)

@suncoastkid
Copy link

App just barely works, occasionally. The rest of the time it's completely broken on Android.

@KRTirtho
Copy link
Owner

So we've gone over almost a full Major version cycle from v2.7 to v3.8

  • We've migrated from audio_players and just_audio to mpv based media_kit so audio latency and playback issues have gone significantly down.
  • There is now a Logs page in "Settings" > "Developers" > "Logs"
  • Tracks starts to play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI A suggestion/bug report of a UI element
Projects
None yet
Development

No branches or pull requests

6 participants