Skip to content

[Bug] Cannot see the correct number of song since 100 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
sf0nt opened this issue Dec 13, 2022 · 5 comments
Closed
1 task done

[Bug] Cannot see the correct number of song since 100 #347

sf0nt opened this issue Dec 13, 2022 · 5 comments
Assignees
Labels
bug Something isn't working deployed This issue has been fixed/implmented and has been released

Comments

@sf0nt
Copy link
Contributor

sf0nt commented Dec 13, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I don't see the correct number of song since 100. I only see the first two numbers of the songs.

I tried to reproduce in Android and I had the same result.

i.e.:
85 => 85
99 => 99
100 => 10
102 => 10
109 => 10
115 => 11

Linux:
image

Android:
image

Expected Behavior

See 3 characters instead of 2 to see the correct number of the songs

Steps To Reproduce

  1. Browse
  2. Select a list that has more than 99 songs
  3. Scroll at the end

Spotube Version

v2.6.0

Operating System

Android, Linux

Linux Distribution (if applicable)

Linux Mint 21 Cinnamon

Operating System Version

Linux Mint 21 Cinnamon and Android 12

Installation Source

Flathub (Flatpak)

Additional information

No response

@sf0nt sf0nt added bug Something isn't working good first issue labels Dec 13, 2022
@KRTirtho
Copy link
Owner

Ok, it's a UI bug

@sf0nt
Copy link
Contributor Author

sf0nt commented Dec 13, 2022

@KRTirtho I found the problem but I cannot debug because I have an error in master branch. It doesn't found the file spotube/models/generated_secrets.dart

I think the width should be 35 in file spotube/lib/components/shared/track_table/track_tile.dart line 199

image

@KRTirtho
Copy link
Owner

I cannot debug because I have an error in master branch. It doesn't found the file spotube/models/generated_secrets.dart

Only if people read the CONTRIBUTION.md before trying to build
There's instruction about how to run the project
https://github.com/KRTirtho/spotube/blob/master/CONTRIBUTION.md#your-first-code-contribution

@sf0nt
Copy link
Contributor Author

sf0nt commented Dec 14, 2022

I cannot debug because I have an error in master branch. It doesn't found the file spotube/models/generated_secrets.dart

Only if people read the CONTRIBUTION.md before trying to build There's instruction about how to run the project https://github.com/KRTirtho/spotube/blob/master/CONTRIBUTION.md#your-first-code-contribution

👍

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 8, 2023

Fixed in v2.7.0

@KRTirtho KRTirtho moved this to Deployed in Spotube Board Mar 8, 2023
@KRTirtho KRTirtho added the deployed This issue has been fixed/implmented and has been released label Mar 8, 2023
@KRTirtho KRTirtho closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from Deployed to Done in Spotube Board Mar 8, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployed This issue has been fixed/implmented and has been released
Projects
Status: Deployed
Development

No branches or pull requests

2 participants