Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI on mac has Windows minus square and x #19

Closed
highjeans opened this issue Feb 3, 2022 · 7 comments · Fixed by #21
Closed

UI on mac has Windows minus square and x #19

highjeans opened this issue Feb 3, 2022 · 7 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@highjeans
Copy link
Contributor

Describe the bug
On MacOS the title bar contains both the radio buttons that are on mac and the Windows buttons. Also in settings, the back button is under the macOS radio buttons.

To Reproduce
Steps to reproduce the behavior:

  1. Login
  2. Look at the top right and left
  3. Click on the gear
  4. Look at the top left.

Screenshots
Screen Shot 2022-02-02 at 4 15 36 PM
Screen Shot 2022-02-02 at 4 17 24 PM

Desktop (please complete the following information):

  • OS: MacOS
@highjeans highjeans added the bug Something isn't working label Feb 3, 2022
@KRTirtho
Copy link
Owner

KRTirtho commented Feb 3, 2022

@highjeans I fixed the issue. Can you check again & submit new screentshots with it?

@highjeans
Copy link
Contributor Author

Ok so now the back arrow in settings is oddly placed, but the windows style title bar is gone now.
Screen Shot 2022-02-03 at 7 10 29 PM

@KRTirtho
Copy link
Owner

KRTirtho commented Feb 4, 2022

Currently the titlebar buttons are provided by macos itself & those buttons aren't available in the widget tree. Thus there is no spacing information available for those titlebar buttons. So I'm kind of guessing the size information & placing the widgets according to it
bitsdojo_window package is working on this issue bitsdojo/bitsdojo_window#62 & bitsdojo/bitsdojo_window#111

@KRTirtho
Copy link
Owner

KRTirtho commented Feb 4, 2022

I re-positioned the leading section of the titlebar. Can you check if it's better than before in your time?

@highjeans
Copy link
Contributor Author

The back button can be positioned a bit more to the left, but is better than before.
Screen Shot 2022-02-03 at 9 14 35 PM

@KRTirtho
Copy link
Owner

KRTirtho commented Feb 4, 2022

Can you edit the value of this file to find the best possible padding & create a PR?

width: MediaQuery.of(context).size.width * 0.07,

@highjeans
Copy link
Contributor Author

Ok I will do that when I can.

@KRTirtho KRTirtho linked a pull request Feb 5, 2022 that will close this issue
@KRTirtho KRTirtho closed this as completed Feb 5, 2022
@lorypelli lorypelli mentioned this issue Sep 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants