Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving the LocalizedOutboundLink component to a separate npm package #2020

Open
toolness opened this issue Mar 30, 2021 · 0 comments

Comments

@toolness
Copy link
Collaborator

Reviewing JustFixNYC/who-owns-what#443 made me realize that there's a need for this handy component (see e.g. #1545 for some explanation of its usefulness) in our other codebases. It might be nice to have it be a package in our justfix-ts monorepo so they can use it.

The main wrinkle is figuring out what to do with its use of SupportedLocale, since each project will have its own concept of a supported locale. We could add it as a parameter to a generic type but that could make things really complicated, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant