Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Underscore Entity Property Names #518

Open
ceelias opened this issue Aug 3, 2021 · 1 comment
Open

Validate Underscore Entity Property Names #518

ceelias opened this issue Aug 3, 2021 · 1 comment

Comments

@ceelias
Copy link
Contributor

ceelias commented Aug 3, 2021

Ran into an issue with OneLogin integration when it was upgraded to new SDK where one of the Entities had a left over underscore property name: _icon

As it was being tested in the graph project with yarn start command and wasn't uploading any data, it didn't throw any errors. The issue arose when it was tested in dev environment: UPLOAD_ERROR

This issue is to add validation in test tooling and runtime for these property values.

@ndowmon
Copy link
Contributor

ndowmon commented Aug 4, 2021

Great suggestion @ceelias! I think the validation inside createIntegrationEntity might be a good place for this. https://github.com/JupiterOne/sdk/blob/main/packages/integration-sdk-core/src/data/createIntegrationEntity.ts#L128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants