This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
INT-6423 Asset tags support #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let tagKey; | ||
| return data.reduce((obj, curTag) => { | ||
| tagKey = `tags.${curTag.key}`; | ||
| if (Object.keys(obj).indexOf(tagKey) != -1) { |
There was a problem hiding this comment.
Why not tagKey in obj?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is supported internally by JupiterOne, however the current implementation is not fully compatible with tenable tag properties specifically the support of multiple tags and accepting them in the form of tag.:[] as payload.
Any tag data automatically gets converted into tag.: via assignTags. This can't be overridden as any attempt to fill tags property or create tag. automatically gets replaced with tags generated by this function.
Currently, assignTags and assignTagMap only supports one tag at a time. If support for multiple tags are needed, this can be included by adding support for multiple tags in JupiterOne sdk or using a different property like tags.:.
This 'solution' will add multiple tags on a different property via
tags.<key>although a more appropriate solution might be to add multiple tags support in the sdk by updating assignTags and assignTagMap.