This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
INT-8998: refactor compute service #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonaldEAM
approved these changes
Feb 7, 2024
| test( | ||
| STEP_COMPUTE_INSTANCE_SERVICE_ACCOUNT_RELATIONSHIPS, | ||
| async () => { | ||
| const stepTestConfig: StepTestConfig = { |
There was a problem hiding this comment.
Not for this pr but, you might want to extract this to a function in the long run
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_ADDRESSES, async () => { |
There was a problem hiding this comment.
Is this .skip necessary? Can we add a comment why we are skipping?
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_FORWARDING_RULES, async () => { |
There was a problem hiding this comment.
This one is also skipped
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_GLOBAL_ADDRESSES, async () => { |
There was a problem hiding this comment.
This one as well
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_GLOBAL_FORWARDING_RULES, async () => { |
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_INSTANCES, async () => { |
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_LOADBALANCERS, async () => { |
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_REGION_TARGET_HTTPS_PROXIES, async () => { |
There was a problem hiding this comment.
One more .skip
| if (recording) await recording.stop(); | ||
| }); | ||
|
|
||
| test.skip(STEP_COMPUTE_SSL_POLICIES, async () => { |
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.