This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
INT-8299: adding integration project support for auto
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl45082
added
patch
sl45082
commented
May 15, 2023
mishelashala
previously approved these changes
May 16, 2023
Nick-NCSU
reviewed
May 16, 2023
Comment on lines
24
to
25
| core.setOutPut('integrationName', 'integration-google-cloud') | ||
| core.setOutPut('graphProjectName', 'google-cloud') |
There was a problem hiding this comment.
Suggested change
| core.setOutPut('integrationName', 'integration-google-cloud') | |
| core.setOutPut('graphProjectName', 'google-cloud') | |
| core.setOutput('integrationName', 'integration-google-cloud') | |
| core.setOutput('graphProjectName', 'google-cloud') |
Or to avoid using the deprecated core.setOutput more I would recommend removing these 2 lines and on line 8 using
jobs:
j1-integration-deployment:
runs-on: ubuntu-latest
env:
IntegrationName: integration-google-cloud
GraphProjectName: google-cloudand you can refer to them with $IntegrationName and $GraphProjectName
There was a problem hiding this comment.
thanks @Nick-NCSU , committing suggested changes.
Nick-NCSU
reviewed
May 16, 2023
Co-authored-by: Nick Thompson <[email protected]>
sl45082
dismissed stale reviews from mishelashala and JuanManuelIbarlucea
via
0a00553
…nto INT-8229 accepted a commit on github.com and merging that into local branch.
sl45082
commented
May 16, 2023
There was a problem hiding this comment.
@Nick-NCSU updated vars as suggested. had a branch issue, so full file showing again.
Nick-NCSU
previously approved these changes
May 16, 2023
mishelashala
previously approved these changes
May 16, 2023
sl45082
commented
May 16, 2023
There was a problem hiding this comment.
@mishelashala and @JuanManuelIbarlucea i fixed the env var references
Nick-NCSU
approved these changes
May 16, 2023
mishelashala
approved these changes
May 16, 2023
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.