This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Consolidate event log names for better user experience #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VDubber
commented
Apr 17, 2023
VDubber
commented
- prettier
VDubber
added
minor
| logger.publishInfoEvent({ | ||
| name: '[service_disabled]' as IntegrationInfoEventName, | ||
| logger.publishWarnEvent({ | ||
| name: 'step_skip' as IntegrationWarnEventName, |
There was a problem hiding this comment.
Is this outside of the allowed values for IntegrationWarnEventName? What's the reason for type casting it?
There was a problem hiding this comment.
Yes, currently that is true.
My focus is to first get the new job status out the door. Follow on work will include adding all used eventNames to the sdk. Most event names are currently strings scattered throughout integrations and even the sdk.
ndowmon
reviewed
Apr 19, 2023
publishEvent -> publishWarnEvent Co-authored-by: Nick Dowmon <[email protected]>
# Conflicts: # src/getStepStartStates.ts
…' into INT-7753-consolidate-event-names
zemberdotnet
approved these changes
Apr 25, 2023
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.