This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
fix(INT-6744): add debug log if timeout error #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowmon
reviewed
Feb 24, 2023
Comment on lines
61
to
67
| if (err.code === 'ATTEMPT_TIMEOUT') { | ||
| logger.warn( | ||
| `${CloudBuildEntitiesSpec.BUILD_BITBUCKET_SERVER_CONFIG._type} - Unable to fetch BitBucket repositories. This might be caused by expired credentials in the GCP console (Cloud Build).`, | ||
| ); | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| throw err; |
There was a problem hiding this comment.
I think it would be better to try/catch inside client.iterateBuildBitBucketRepositories(). If we encounter ATTEMPT_TIMEOUT here, let's not throw (but throw if encountering any other errors).
gastonyelmini
commented
Feb 24, 2023
| if (err.code === 'ATTEMPT_TIMEOUT') { | ||
| context.logger.warn( | ||
| { err }, | ||
| `${CloudBuildEntitiesSpec.BUILD_BITBUCKET_SERVER_CONFIG._type} - Unable to fetch BitBucket repositories. This might be caused by expired credentials in the GCP console (Cloud Build).`, |
There was a problem hiding this comment.
The name of the variable is CloudBuildEntitiesSpec but actually comes from a constants file
ndowmon
reviewed
Feb 24, 2023
src/steps/cloud-build/client.ts
Outdated
Comment on lines
164
to
166
| } | ||
|
|
||
| throw err; |
There was a problem hiding this comment.
I suggest the following so that the step does not fail if ATTEMPT_TIMEOUT occurs.
Suggested change
| } | |
| throw err; | |
| } else { | |
| throw err; | |
| } |
ndowmon
approved these changes
Feb 24, 2023
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add debug log if timeout error
Context:
Google Cloud does not handle correctly errors when BitBucket credentials are expired. Added a log in order to make it more easy to debug in the future.