This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
feat(INT-6665): review GCP permissions #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonyelmini
commented
Jan 19, 2023
husky.config.js
Outdated
| module.exports = { | ||
| hooks: { | ||
| ...huskyConfig.hooks, | ||
| 'pre-commit': `${huskyConfig.hooks['pre-commit']} && yarn document:permissions && git add docs/jupiterone.md`, |
There was a problem hiding this comment.
This will run SDK commands together with the document:permissions one.
There was a problem hiding this comment.
You may want to do yarn lint-staged afterwards... so might be worth running the huskyConfig's pre-commit after your script. Not a big deal though.
There was a problem hiding this comment.
thank you for your comments! will update that
gastonyelmini
force-pushed
the
INT-6665-permissions-review
branch
4 times, most recently
from
64f6500 to
6c55fc7
Compare
ndowmon
reviewed
Jan 25, 2023
Comment on lines
+38
to
+40
| chalk.gray( | ||
| 'DOCUMENT PERMISSIONS (START): Collecting permissions from steps...', | ||
| ), |
gastonyelmini
force-pushed
the
INT-6665-permissions-review
branch
from
6c55fc7 to
f1d03cf
Compare
gastonyelmini
force-pushed
the
INT-6665-permissions-review
branch
from
f1d03cf to
1abcf88
Compare
ndowmon
approved these changes
Jan 30, 2023
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review GCP permissions and generate permissions list.