This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Refactor storage bucket constants #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i5o
reviewed
Nov 7, 2022
| @@ -15,7 +15,7 @@ import { | |||
| } from './constants'; | |||
| import { CloudSourceRepositoriesStepsSpec } from '../cloud-source-repositories/constants'; | |||
| import { cloudfunctions_v1 } from 'googleapis'; | |||
| import { STEP_CLOUD_STORAGE_BUCKETS } from '../storage'; | |||
There was a problem hiding this comment.
Can we get rid of this and use the new constant?
i5o
reviewed
Nov 7, 2022
src/steps/storage/constants.ts
Outdated
| @@ -2,3 +2,18 @@ export const CLOUD_STORAGE_BUCKET_ENTITY_CLASS = 'DataStore'; | |||
| export const CLOUD_STORAGE_BUCKET_ENTITY_TYPE = 'google_storage_bucket'; | |||
|
|
|||
| export const STEP_CLOUD_STORAGE_BUCKETS = 'fetch-cloud-storage-buckets'; | |||
There was a problem hiding this comment.
We should be able to remove these lines
gastonyelmini
force-pushed
the
storage-constants-refactor
branch
from
8405221 to
1182ed7
Compare
i5o
previously approved these changes
Nov 7, 2022
ndowmon
reviewed
Nov 7, 2022
src/steps/app-engine/index.ts
Outdated
| CLOUD_STORAGE_BUCKET_ENTITY_TYPE, | ||
| STEP_CLOUD_STORAGE_BUCKETS, | ||
| } from '../storage'; | ||
| import { StorageEntitiesSpec, StorageStepsSpec } from '../storage'; |
There was a problem hiding this comment.
Can you remove the export * from './constants' line from storage/index.ts? Exporting from index.ts can quickly lead to circular dependencies, so it's much better to always import from constants and to stop the practice of export * from './constants'.
Suggested change
| import { StorageEntitiesSpec, StorageStepsSpec } from '../storage'; | |
| import { StorageEntitiesSpec, StorageStepsSpec } from '../storage/constants'; |
There was a problem hiding this comment.
Updated in commit f007ff0 :)
gastonyelmini
force-pushed
the
storage-constants-refactor
branch
from
1182ed7 to
f007ff0
Compare
gastonyelmini
force-pushed
the
INT-5917-cloud-function-relationship
branch
4 times, most recently
from
87b7d88 to
44fd8ab
Compare
gastonyelmini
force-pushed
the
storage-constants-refactor
branch
from
f007ff0 to
d26edbe
Compare
gastonyelmini
force-pushed
the
storage-constants-refactor
branch
from
d26edbe to
2dd5a03
Compare
ndowmon
approved these changes
Nov 10, 2022
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
storageconstants to match new structure requirements.