This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
feat(INT-5917): add cloud function storage bucket relationship #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonyelmini
commented
Nov 4, 2022
| const cloudFunction = | ||
| getRawData<cloudfunctions_v1.Schema$CloudFunction>(cloudFunctionEntity); | ||
|
|
||
| const storageBucketKey = cloudFunction?.sourceArchiveUrl?.split('/')[2]; |
There was a problem hiding this comment.
soruceArchivrUrl would be something like gs://[bucket-id]/[file-name].
|
Looking at the build result it looks like you forgot to add this step to the index test; just a heads up |
i5o
reviewed
Nov 4, 2022
i5o
reviewed
Nov 4, 2022
i5o
reviewed
Nov 4, 2022
gastonyelmini
force-pushed
the
INT-5917-cloud-function-relationship
branch
from
0caa9dc to
301013c
Compare
i5o
reviewed
Nov 4, 2022
gastonyelmini
force-pushed
the
INT-5917-cloud-function-relationship
branch
from
301013c to
85ccb2b
Compare
i5o
previously approved these changes
Nov 5, 2022
ndowmon
reviewed
Nov 7, 2022
ndowmon
reviewed
Nov 7, 2022
ndowmon
reviewed
Nov 7, 2022
gastonyelmini
force-pushed
the
INT-5917-cloud-function-relationship
branch
3 times, most recently
from
a0879e6 to
87b7d88
Compare
ndowmon
previously approved these changes
Nov 8, 2022
i5o
suggested changes
Nov 9, 2022
gastonyelmini
force-pushed
the
INT-5917-cloud-function-relationship
branch
from
87b7d88 to
44fd8ab
Compare
i5o
approved these changes
Nov 9, 2022
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds Google Cloud Functions Source Repository Relation.