Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

feat(INT-5918): add cloud function source repo relationship #553

Merged
merged 1 commit into from
Nov 2, 2022
Merged

feat(INT-5918): add cloud function source repo relationship #553

merged 1 commit into from
Nov 2, 2022

Conversation

gastonyelmini
Copy link
Contributor

Context

Adds Google Cloud Functions Source Repository Relation.

Captura de Pantalla 2022-10-31 a la(s) 09 40 16

@gastonyelmini gastonyelmini force-pushed the INT-5918-cloud-function-relationship branch from ef31760 to b5d4a54 Compare October 31, 2022 13:20
@gastonyelmini gastonyelmini force-pushed the INT-5918-cloud-function-relationship branch 2 times, most recently from 05c8d2b to 7ebb364 Compare October 31, 2022 21:50
@gastonyelmini gastonyelmini marked this pull request as ready for review October 31, 2022 21:51
@gastonyelmini gastonyelmini requested a review from a team as a code owner October 31, 2022 21:51
@gastonyelmini gastonyelmini force-pushed the INT-5918-cloud-function-relationship branch from 7ebb364 to a36565b Compare November 1, 2022 15:55
i5o
i5o reviewed Nov 1, 2022
View reviewed changes
src/steps/functions/index.ts Outdated Show resolved Hide resolved
i5o
i5o previously approved these changes Nov 1, 2022
View reviewed changes
ndowmon
ndowmon reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@ndowmon ndowmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It's pretty tricky that this property does not match the _key of the source repo. I've made a few small suggestions - let me know what you think.

@gastonyelmini gastonyelmini force-pushed the INT-5918-cloud-function-relationship branch from a36565b to 488b726 Compare November 2, 2022 12:15
@gastonyelmini gastonyelmini requested review from ndowmon and i5o November 2, 2022 12:27
@ndowmon ndowmon added minor Increment the minor version when merged release Create a release when this pr is merged labels Nov 2, 2022
@gastonyelmini gastonyelmini merged commit 4f7ccfa into main Nov 2, 2022
@gastonyelmini gastonyelmini deleted the INT-5918-cloud-function-relationship branch November 2, 2022 16:52
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v2.19.0 🚀

@j1-internal-automation j1-internal-automation added the released This issue/pull request has been released. label Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ndowmon ndowmon ndowmon approved these changes

@i5o i5o Awaiting requested review from i5o

Assignees
No one assigned
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gastonyelmini @j1-internal-automation @i5o @ndowmon