This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
INT-4507 - Add users property to compute address entities
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New properties added to resources: | Entity | Properties | | ------------------------------- | ---------- | | `google_compute_global_address` | `users` | | `google_compute_address` | `users` |
i5o
approved these changes
Sep 6, 2022
JakeFerrero
reviewed
Sep 6, 2022
|
|
||
| ### In Google Cloud | ||
|
|
||
| A [Google Cloud service account](https://cloud.google.com/iam/docs/creating-managing-service-accounts) and a [Google Cloud service account key](https://cloud.google.com/iam/docs/creating-managing-service-account-keys) | ||
| A |
There was a problem hiding this comment.
Formatting seems off here
There was a problem hiding this comment.
Ya this was prettier. I think it chose a new line length due to the URL.
JakeFerrero
reviewed
Sep 6, 2022
| @@ -122,17 +129,19 @@ to enable all services that the JupiterOne integration supports: | |||
|
|
|||
| #### Creating Google Cloud project service account | |||
|
|
|||
| * See the [Google Cloud service account documentation](https://cloud.google.com/iam/docs/creating-managing-service-accounts#creating) for more information on how to create a | |||
| service account in the project that you would like to ingest data from. | |||
| - See the | |||
There was a problem hiding this comment.
Was prettier run or something? I think a lot of the formatting changes here aren't needed. If I had to guess, prettier is taking into account the whole [text](url) string when deciding on when to move to the next line, even though the [text] part is the only thing that will actually be visible to the reader.
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New properties added to resources:
google_compute_global_addressusersgoogle_compute_addressusers