This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
add more record type properties #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeaBlooms
added
minor
VDubber
reviewed
Aug 6, 2024
| // AAAA type | ||
| aaaaRecords: data.aaaaRecords, | ||
| // NS type | ||
| nsRecords: data.nsRecords, |
There was a problem hiding this comment.
what is the data type of these values? array of string?
There was a problem hiding this comment.
objects / dictionaries are not supported, nor are lists of objects/dictionaries!
if nsRecords is an object like:
{ val: "one", val2: "two" }
this will not be accepted by the data pipeline.
They must be converted to a data type that is supported (primitives or arrays of primitives) or be JSON.stringify() 'ed
Gonzalo-Avalos-Ribas
approved these changes
Aug 13, 2024
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.