-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue512 #532
Issue512 #532
Conversation
So I'm thinking this one will sit on hold for now until #529 is merged. Then we can work on making sure only the contributing changes are in this PR |
@1701home - Can you be more descriptive in the future with your PR titles and also commit messages? I'm struggling to really wrap my head around an initial understanding of what this PR is solving, esp since there are seemingly some scraper commits mixed in aswell? I do see #512 referenced, but that too is a little vague. For now, a quick description here of what this PR is attempting to accomplish would be really helpful. |
@gerbrent - Understood, this PR was a nightmare, and I had to get support. I added the "How to Add JS for a Page" mentioned in the issue's OP. Afterward, I added links to the videos specified in the second comment on the issue. Finally, I added a link to the top of the page for both added items. If anything is missing or wrong I will be happy to fix or remove the PR. Also, If I submitted any new PRs I will be more descriptive. Thank you! |
No problem @1701home ! Nightmares are ok, as long as you feel you're getting support and guidance on how to improve in those areas, which it sounds like you are at that's a complete success! We're all here to learn a little something, be it how to do open source collaboratively, improving our git chops, learning a new language or the GH interface or anything else! So, please, no worries... happy you're making progress on the PR and thank you for submitting your ideas and talents! |
Thank you very much, @gerbrent ! It is very nice to have people like @CGBassPlayer and yourself to help show the way. I really enjoy doing this, too. I am excited to see what I can do with my new tools this weekend! |
Closes #512