Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue512 #532

Closed
wants to merge 6 commits into from
Closed

Issue512 #532

wants to merge 6 commits into from

Conversation

1701home
Copy link
Contributor

Closes #512

Merched the following files and then updated the show notes for each episode they were in.
Closes #521

Per CGBassPlayer's comments
Closes 512
@CGBassPlayer
Copy link
Collaborator

So I'm thinking this one will sit on hold for now until #529 is merged. Then we can work on making sure only the contributing changes are in this PR

@CGBassPlayer CGBassPlayer added the blocked is blocked by another issue/PR label Mar 26, 2023
@gerbrent
Copy link
Collaborator

@1701home - Can you be more descriptive in the future with your PR titles and also commit messages?

I'm struggling to really wrap my head around an initial understanding of what this PR is solving, esp since there are seemingly some scraper commits mixed in aswell?

I do see #512 referenced, but that too is a little vague.
Thank you!

For now, a quick description here of what this PR is attempting to accomplish would be really helpful.

@1701home
Copy link
Contributor Author

@gerbrent - Understood, this PR was a nightmare, and I had to get support. I added the "How to Add JS for a Page" mentioned in the issue's OP. Afterward, I added links to the videos specified in the second comment on the issue. Finally, I added a link to the top of the page for both added items. If anything is missing or wrong I will be happy to fix or remove the PR.

Also, If I submitted any new PRs I will be more descriptive.

Thank you!

@1701home 1701home closed this Mar 29, 2023
@1701home 1701home deleted the Issue512 branch March 29, 2023 22:40
@gerbrent
Copy link
Collaborator

No problem @1701home ! Nightmares are ok, as long as you feel you're getting support and guidance on how to improve in those areas, which it sounds like you are at that's a complete success! We're all here to learn a little something, be it how to do open source collaboratively, improving our git chops, learning a new language or the GH interface or anything else!

So, please, no worries... happy you're making progress on the PR and thank you for submitting your ideas and talents!

@1701home
Copy link
Contributor Author

Thank you very much, @gerbrent ! It is very nice to have people like @CGBassPlayer and yourself to help show the way. I really enjoy doing this, too. I am excited to see what I can do with my new tools this weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked is blocked by another issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the CONTRIBUTING.md file
3 participants