Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide convenience helper function for constructing file:/// URIs? #241

Closed
vtjnash opened this issue May 1, 2018 · 4 comments
Closed

Comments

@vtjnash
Copy link
Member

vtjnash commented May 1, 2018

For example, see code and tests in PR to URIParser.jl: https://github.com/JuliaWeb/URIParser.jl/pull/60/files#diff-6c68f903474362a5d56664b6304e491bR59

@samoconnor
Copy link
Contributor

Seems useful.

I wonder if it should be URI(::Base.FilePath)?
i.e. instead of putting the type in the method name (URI_file), add a type for strings that represent a local file path. This would be generally useful in many places.
(But I wouldn't want to force people to say read(FilePath("myfile")) where they can currently say read("myfile")).

@vtjnash
Copy link
Member Author

vtjnash commented May 1, 2018

What's Base.FilePath?

julia> Base.FilePath
ERROR: UndefVarError: FilePath not defined

@samoconnor
Copy link
Contributor

What's Base.FilePath?

... add a type for strings that represent a local file path.

@quinnj
Copy link
Member

quinnj commented May 3, 2018

ref: JuliaLang/Juleps#26

@quinnj quinnj closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants