Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wts keyword argument name to weights #350

Open
pdeffebach opened this issue Dec 31, 2019 · 4 comments · May be fixed by #570
Open

Change wts keyword argument name to weights #350

pdeffebach opened this issue Dec 31, 2019 · 4 comments · May be fixed by #570
Assignees
@andreasnoack
Labels
decision
Milestone
Release 2.0

Comments

@pdeffebach
Copy link
Contributor

As mentioned in #341 , wts is a bit esoteric and unclear. Better to use weights as the name of the keyword argument for weights.

Let me know your thoughts on changing the name of keyword argument or if I should change the name of the field in GlmResp, LmResp etc. as well.
@nalimilan
Copy link
Member

Probably better also rename the field, though that's secondary.

@pdeffebach
Copy link
Contributor Author

Actually, weights should go in the formula call.

I'm about to spend a lot of time re-writing R-code because the observations that have NA are different than the weights that have NA and I want all of them. One way to handle this is to have StatsModels take care of it when creating the model matrix.

@nalimilan
Copy link
Member

It's been discussed a few times before (JuliaStats/StatsModels.jl#21). One alternative possibility would be to pass a symbol or string to the weights argument, and have a way to pass this to StatsModels when constructing the model matrix. We should settle this in StatsModels.

@jariji
Copy link

jariji commented Aug 29, 2022

One alternative possibility would be to pass a symbol or string to the weights argument

That's what FixedEffectModels.jl does

@palday palday mentioned this issue Sep 29, 2022
Open
@andreasnoack andreasnoack linked a pull request Nov 19, 2024 that will close this issue
Open
@andreasnoack andreasnoack self-assigned this Nov 20, 2024
@andreasnoack andreasnoack added this to the Release 2.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasnoack andreasnoack

Labels
decision
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging a pull request may close this issue.

Change all uses of wts to weights JuliaStats/GLM.jl
4 participants
@andreasnoack @nalimilan @pdeffebach @jariji