Propagate NaNs and update tests #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will close #259. |
|
@devmotion - if you're happy with this I don't know if you want me to bump the package patch version in the PR as well? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
===========================================
+ Coverage 78.73% 95.86% +17.13%
===========================================
Files 10 10
Lines 602 944 +342
===========================================
+ Hits 474 905 +431
+ Misses 128 39 -89 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Nov 29, 2023
|
Okay, thanks. I've added back in testing of differing input types for GKL and new testing for KL divergences. |
…ces.jl into rr/kl_fix # Conflicts: # Project.toml
|
Okay @devmotion, I've merged your changes (thanks). I was also trying to fix stdlib dependency issues for a new package release and I reinvented part of #258, so I've merged it in including bumping the package version. If you're happy with that, I'm done now (I hope!). |
devmotion
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #259.