Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Julia v0.7 compatibility #301

Open
nico202 opened this issue Jun 17, 2018 · 9 comments
Open

Julia v0.7 compatibility #301

nico202 opened this issue Jun 17, 2018 · 9 comments

Comments

@nico202
Copy link

nico202 commented Jun 17, 2018

Hi, trying to install this on julia v0.7 and getting lot of warnings + errors. Last commit might address this, is it possible to tag a relase and update uncurated.jl? Thanks

@nalimilan
Copy link
Member

Unfortunately I still get an error when loading even on master. Apparently Femtocleaner will soon be working, which should fix most deprecations. Then we'll need somebody to fix the more serious errors.

@nalimilan
Copy link
Member

Though note that DataArrays shouldn't really be needed on 0.7 since Array{Union{T,Missing}} is fast (though maybe not always as fast as DataArray{T}).

@nico202
Copy link
Author

nico202 commented Jun 18, 2018

@nalimilan thanks. I wanted to try Queryverse on 0.7, so maybe I'd just have to wait for them to fix it and tag the release

@phaverty
Copy link

RCall.jl still depends on DataArrays.jl. I don't know if they plan to move away from DataArrays.jl or not. It would be quite nice to have RCall.jl on 0.7 sooner, rather than later, if updating DataArrays.jl is straightforward. Anything I can do to help? Precompiling DataArrays.jl generates various deprecation warnings, which I can live with, but it errors on "ipermute!! not defined". Maybe the second ! is just a typo?

@nalimilan
Copy link
Member

It's not a typo, it's just been renamed to Base.invpermute!! in 0.7. A PR using the new name when VERSION >= v"0.7.0-DEV.3173" would be welcome.

@ararslan
Copy link
Member

ararslan commented Jun 27, 2018

RCall.jl still depends on DataArrays.jl. I don't know if they plan to move away from DataArrays.jl or not.

They should. Perhaps a PR to RCall would be even better, moving it to using Array{Union{T,Missing}} instead of DataArray{T}. I'd be happy to review that.

@nalimilan
Copy link
Member

nalimilan commented Jun 27, 2018

RCall should definitely make the switch (and IIRC it already supports Array{Union{T,Missing}}), but it should probably continue depending on DataArray for a while just for compatibility (i.e. just to accept such arrays).

@nalimilan
Copy link
Member

I guess the part which will require the most work to port is src/broadcast.jl. That won't be trivial to do.

@phaverty
Copy link

It looks like RCall may just drop DataArrays for 0.7, since it already supports Array{Union{T,Missing}}. Please see their issue 247. That seems like a nice, tidy solution. 0.7 seems like a good time for a bit of breakage.

@nico202 nico202 changed the title tag release Julia v0.7 compatibility Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants