Tests fail on 0.6: no method matching size(::Type{DataArrays.DataArray})

[ararslan]

This is what Pkg.test("DataArrays") is giving me on Julia master:

Running tests:
 * abstractarray.jl
 * booleans.jl
ERROR: LoadError: LoadError: MethodError: no method matching size(::Type{DataArrays.DataArray})
Closest candidates are:
  size{N}(::Any, ::Integer, ::Integer, ::Integer...) at abstractarray.jl:23
  size(::BitArray{1}) at bitarray.jl:49
  size(::BitArray{1}, ::Any) at bitarray.jl:53
  ...
Stacktrace:
 [1] broadcast_indices(::Type{Array}, ::Type{T}) at ./broadcast.jl:62
 [2] broadcast_indices(::Array{DataType,1}, ::Type{T}) at ./broadcast.jl:63
 [3] broadcast_c(::Function, ::Type{Array}, ::Array{DataType,1}, ::DataType, ::Vararg{DataType,N}) at ./broadcast.jl:311
 [4] broadcast at ./broadcast.jl:454 [inlined]
 [5] gen_broadcast_dataarray(::Int64, ::Tuple{DataType}, ::Type{T}, ::Function) at /Users/alex/.julia/v0.6/DataArrays/src/broadcast.jl:91
 [6] get!(::DataArrays.##131#137{TestBooleans.##1#2,Tuple{DataArrays.DataArray{Int64,1}},Int64}, ::Dict{Int64,Function}, ::Int64) at ./dict.jl:432
 [7] broadcast!(::Function, ::DataArrays.DataArray{Int64,1}, ::DataArrays.DataArray{Int64,1}) at /Users/alex/.julia/v0.6/DataArrays/src/broadcast.jl:226
 [8] broadcast(::Function, ::DataArrays.DataArray{Int64,1}) at /Users/alex/.julia/v0.6/DataArrays/src/broadcast.jl:296
 [9] include_from_node1(::String) at ./loading.jl:532
 [10] include(::String) at ./sysimg.jl:14
 [11] include(::String) at /Users/alex/Projects/julia/usr/lib/julia/sys.dylib:?
 [12] macro expansion; at /Users/alex/.julia/v0.6/DataArrays/test/runtests.jl:38 [inlined]
 [13] anonymous at ./<missing>:?
 [14] include_from_node1(::String) at ./loading.jl:532
 [15] include_from_node1(::String) at /Users/alex/Projects/julia/usr/lib/julia/sys.dylib:?
 [16] include(::String) at ./sysimg.jl:14
 [17] include(::String) at /Users/alex/Projects/julia/usr/lib/julia/sys.dylib:?
 [18] process_options(::Base.JLOptions) at ./client.jl:298
 [19] _start() at ./client.jl:363
 [20] _start() at /Users/alex/Projects/julia/usr/lib/julia/sys.dylib:?
while loading /Users/alex/.julia/v0.6/DataArrays/test/booleans.jl, in expression starting on line 17
while loading /Users/alex/.julia/v0.6/DataArrays/test/runtests.jl, in expression starting on line 36

So I guess somewhere we're calling size(DataArray), i.e. calling size on the type literal?

[nalimilan]

Probably due to changes in broadcast in Base.

[Sacha0]

Reduced to broadcast(==, [1], AbstractArray), and fixed by JuliaLang/julia#19922. Thanks @ararslan!

[ararslan]

Thanks so much, @Sacha0! You're the best!

[ararslan]

Fixed but never closed.