Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports to v1.10 #572

Merged
merged 9 commits into from
Nov 3, 2024
Merged

Backports to v1.10 #572

merged 9 commits into from
Nov 3, 2024

Conversation

dkarrasch
Copy link
Member

No description provided.

@dkarrasch
Copy link
Member Author

Do we have more to add here? Otherwise, we should merge this and then bump it into JuliaLang/julia#56381.

@ViralBShah
Copy link
Member

ViralBShah commented Nov 1, 2024

I think we want #560, #557, #550 (but that PR seems to have other noisy stuff).

There are several others marked as backport to 1.10, but many probably have already been backported. Perhaps we should remove the labels?

@ViralBShah
Copy link
Member

Should we update the CI on this branch to run on 1.10?

@dkarrasch
Copy link
Member Author

Oh, I forgot about our label, so there's a lot marked for backport, actually. I'll go through the list. CI seems to be running on v1.10?

I can't backport #550. It has quite some heavy merge conflicts that I don't know how to resolve.

@dkarrasch
Copy link
Member Author

There are several others marked as backport to 1.10, but many probably have already been backported. Perhaps we should remove the labels?

I have cleaned up the list. Everything (up to #550) is included and I removed the labels.

@ViralBShah
Copy link
Member

I have cleaned up the list. Everything (up to #550) is included and I removed the labels.

Thank you!

@ViralBShah
Copy link
Member

I isolated the commit for disabling nested dissection and pushed it. Unfortunately, instead of a branch I pushed directly to release-1.10. Also updated the CI. I might need to push a few more to make sure it all ends up working out.

@ViralBShah
Copy link
Member

ViralBShah commented Nov 2, 2024

Would it be ok to remove those commits and force push on the 1.10 branch? Or should we just revert them? I created a new PR against the backports-release-1.10 branch in #577.

@ViralBShah
Copy link
Member

cc @KristofferC

ViralBShah and others added 2 commits November 2, 2024 12:09
* Disable nested dissection (from #550)

* Update CI for Julia 1.10

---------

Co-authored-by: Viral B. Shah <[email protected]>
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (4ddb0bf) to head (ec38631).
Report is 14 commits behind head on release-1.10.

Files with missing lines Patch % Lines
src/linalg.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10     #572      +/-   ##
================================================
- Coverage         93.19%   92.64%   -0.55%     
================================================
  Files                12       12              
  Lines              7667     7670       +3     
================================================
- Hits               7145     7106      -39     
- Misses              522      564      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

Verified that the issue reported in #548 is fixed on this branch.

@dkarrasch
Copy link
Member Author

This seems like done. I'm merging this.

@dkarrasch dkarrasch merged commit 8c84b8c into release-1.10 Nov 3, 2024
7 of 9 checks passed
@dkarrasch dkarrasch deleted the backports-release-1.10 branch November 3, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants