-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports to v1.10 #572
Backports to v1.10 #572
Conversation
Do we have more to add here? Otherwise, we should merge this and then bump it into JuliaLang/julia#56381. |
Should we update the CI on this branch to run on 1.10? |
…ing the test suite (#425)
Fix docs conflict
* SparseMatrixCSC constructor with a Tuple of Integers * SparseVector constructors --------- Co-authored-by: Viral B. Shah <[email protected]>
SPQR uses just the double precision epsilon even for Float32. https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/131471310ef0600b231b8fa7c10a55c3f70afbd9/SPQR/Source/spqr_tol.cpp#L29C6-L30C57
Oh, I forgot about our label, so there's a lot marked for backport, actually. I'll go through the list. CI seems to be running on v1.10? I can't backport #550. It has quite some heavy merge conflicts that I don't know how to resolve. |
I have cleaned up the list. Everything (up to #550) is included and I removed the labels. |
Thank you! |
I isolated the commit for disabling nested dissection and pushed it. Unfortunately, instead of a branch I pushed directly to release-1.10. Also updated the CI. I might need to push a few more to make sure it all ends up working out. |
Would it be ok to remove those commits and force push on the 1.10 branch? Or should we just revert them? I created a new PR against the |
cc @KristofferC |
* Disable nested dissection (from #550) * Update CI for Julia 1.10 --------- Co-authored-by: Viral B. Shah <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #572 +/- ##
================================================
- Coverage 93.19% 92.64% -0.55%
================================================
Files 12 12
Lines 7667 7670 +3
================================================
- Hits 7145 7106 -39
- Misses 522 564 +42 ☔ View full report in Codecov by Sentry. |
Verified that the issue reported in #548 is fixed on this branch. |
This seems like done. I'm merging this. |
No description provided.