Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAIG backward error #121

Merged
merged 4 commits into from
Mar 5, 2019
Merged

CRAIG backward error #121

merged 4 commits into from
Mar 5, 2019

Conversation

dpo
Copy link
Member

@dpo dpo commented Mar 4, 2019

This PR

  • closes CRAIG should stop based on the backward error #119 by implementing a stopping test based on the backward error
  • implements a stopping test for ill-conditioned operators
  • implements an option to transfer to the LSQR point at the end of the iterations
  • removes old useless semicolons from the code.

It's easiest to examine each commit separately.

@dpo dpo changed the title Craig bkward CRAIG backward error Mar 4, 2019
@dpo dpo added the enhancement label Mar 4, 2019
@dpo dpo force-pushed the craig-bkward branch 3 times, most recently from d68f7de to bf1fc6b Compare March 4, 2019 21:19
@amontoison
Copy link
Member

The error with SmallNumber is linked with :
JuliaLang/julia#29662
Maybe we shoud drop julia 0.7?
With julia 1.1, julia 0.7 is not maintained anymore.

@coveralls
Copy link

coveralls commented Mar 4, 2019

Coverage Status

Coverage decreased (-0.1%) to 81.362% when pulling 7c78091 on craig-bkward into 9d8d898 on master.

@dpo
Copy link
Member Author

dpo commented Mar 4, 2019

Yes, let's drop 0.7!

@amontoison
Copy link
Member

Done in #122

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files          21       21           
  Lines        1774     1774           
=======================================
  Hits         1447     1447           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8d898...7c78091. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #121 into master will decrease coverage by 0.16%.
The diff coverage is 77.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   87.03%   86.87%   -0.17%     
==========================================
  Files          21       21              
  Lines        1774     1798      +24     
==========================================
+ Hits         1544     1562      +18     
- Misses        230      236       +6
Impacted Files Coverage Δ
src/craig.jl 83.33% <77.63%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8d898...7c78091. Read the comment docs.

@dpo dpo merged commit ba0c74c into master Mar 5, 2019
@dpo dpo deleted the craig-bkward branch March 5, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAIG should stop based on the backward error
3 participants