Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Julia LTS? #21

Closed
chriselrod opened this issue Dec 5, 2022 · 3 comments · Fixed by #22
Closed

Support Julia LTS? #21

chriselrod opened this issue Dec 5, 2022 · 3 comments · Fixed by #22

Comments

@chriselrod
Copy link
Member

Why have the lower bound 1.6?

I dropped 1.8 for StrideArrays here:
JuliaSIMD/StrideArrays.jl#64
but I'm curious why this is necessary.
@brenhinkeller
Copy link
Collaborator

Ah, so we were at 1.5 traditionally, but I upped it to 1.8 last release so we could use SnoopPrecompile, which IIUC requires 1.8+.

We could probably just put the SnoopPrecompile block behind a @static if VERSION though to support older versions though if you like?

@brenhinkeller
Copy link
Collaborator

(incidentally, SnoopPrecompile pretty much eliminates our TTFX even before switching to Valentin's native code caching branch!)

@brenhinkeller
Copy link
Collaborator

Though looks like maybe I was misunderstanding the bounds on SnoopPrecompile?

@brenhinkeller brenhinkeller mentioned this issue Dec 6, 2022
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert to our traditional Julia 1.5+ compat bounds JuliaSIMD/VectorizedStatistics.jl
2 participants
@chriselrod @brenhinkeller