Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DummySampler samples invalid indices #69

Open
HenriDeh opened this issue Apr 16, 2024 · 1 comment
Open

DummySampler samples invalid indices #69

HenriDeh opened this issue Apr 16, 2024 · 1 comment

Comments

@HenriDeh
Copy link
Member

See JuliaReinforcementLearning/ReinforcementLearning.jl#1068 .

We can either fix DummySampler, or make a new full trajectory sampler. In the former case, I think it should be renamed because it's not really dummy.
@johannes-fischer
Copy link

As I wrote in the linked issue, BatchSampler has the same behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johannes-fischer @HenriDeh