Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDLearner time step parameter #648

Closed
baedan opened this issue Jun 6, 2022 · 3 comments
Closed

TDLearner time step parameter #648

baedan opened this issue Jun 6, 2022 · 3 comments

Comments

@baedan
Copy link
Contributor

baedan commented Jun 6, 2022

TDLearner(;approximator, γ=1.0, method, n=0): the n in the constructor is strangely not the number of time steps used, but rather that number minus 1. this is really strange.

@findmyway
Copy link
Member

;(
I struggled on it too...
In the end, I decided to follow TD(λ) where (λ=0). So maybe better to rename the keyword argument name?

@baedan
Copy link
Contributor Author

baedan commented Jun 6, 2022

isn't TD(λ) separately defined in TDλReturnLearner?

the n here can just be the n as in n-step TD methods, no? it's simple enough to change, but i'm not sure how one would introduce a breaking change (though, funnily enough, the example in RLAnIntroduction.jl took the n to be the number of time steps, lol)

@findmyway
Copy link
Member

Hmm, let me examine it again when adding it back in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants