Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship to DomainSets.jl #14

Open
zsunberg opened this issue Aug 18, 2022 · 2 comments
Open

Relationship to DomainSets.jl #14

zsunberg opened this issue Aug 18, 2022 · 2 comments

Comments

@zsunberg
Copy link
Member

I recently discovered DomainSets.jl. It contains some of the sets we need, for example cartesian products, etc. What should this package's relationship to DomainSets be? I see a few possibilities.

  1. No relationship - we act like DomainSets doesn't exist (but perhaps learn from it)
  2. We maintain compatibility in case someone wants to use things from DomainSets, but also re-implement the functionality that we want here.
  3. We use them as a base package for our interface and encourage using their sets in most cases, and only implement a few things that they don't provide (i.e. we would probably get rid of our product and use theirs.)
  4. We re-export some of their sets like we do with IntervalSets (this seems bad)
  5. We archive this package because DomainSets provides everything we need.
@findmyway
Copy link
Member

findmyway commented Aug 19, 2022

I wish I could have known that package earlier 😭

#3 seems to be more appealing to me. We can archive this package and add those that are not provided into CommonRLInterfaces.jl.

@zsunberg
Copy link
Member Author

Yes, it is a pretty nice package, but doesn't have some things that we want, like rand and clamp, so we will have to work out how to integrate with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants