Fix JuliaInfo.load for Python 2

Author: tkf

julia/core.py

@@ -384,12 +384,15 @@ def load(cls, julia="julia", **popen_kwargs):
         stdout, stderr = proc.communicate()
         retcode = proc.wait()
         if retcode != 0:
-            raise subprocess.CalledProcessError(
-                retcode,
-                [julia, "-e", "..."],
-                stdout,
-                stderr,
-            )
+            if sys.version_info[0] < 3:
+                output = "\n".join(["STDOUT:", stdout, "STDERR:", stderr])
+                raise subprocess.CalledProcessError(
+                    retcode, [julia, "-e", "..."], output
+                )
+            else:
+                raise subprocess.CalledProcessError(
+                    retcode, [julia, "-e", "..."], stdout, stderr
+                )
 
         stderr = stderr.strip()
         if stderr:

test/test_juliainfo.py

@@ -1,7 +1,9 @@
 import os
 import subprocess
 
-from julia.core import JuliaInfo, _enviorn
+import pytest
+
+from julia.core import JuliaInfo, _enviorn, which
 
 
 def check_core_juliainfo(jlinfo):
@@ -47,3 +49,14 @@ def test_juliainfo_without_pycall(tmpdir):
     check_core_juliainfo(jlinfo)
     assert jlinfo.python is None
     assert jlinfo.libpython_path is None
+
+
+@pytest.mark.skipif(
+    not which("false"),
+    reason="false command not found")
+def test_juliainfo_failure():
+    with pytest.raises(subprocess.CalledProcessError) as excinfo:
+        JuliaInfo.load(julia="false")
+    assert excinfo.value.cmd[0] == "false"
+    assert excinfo.value.returncode == 1
+    assert isinstance(excinfo.value.output, str)