-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all errors in start
warnings, actually throw when calling save_payload
#18
Conversation
Only sends warning during `start()`
I ended up removing the variable storing the error message and defaulting to Now a more descriptive error is thrown inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks @BeastyBlacksmith. I'll then merge a publish a new non-breaking release to fix PlotlyJS precompilation |
This PR tries to fix JuliaPlots/PlotlyJS.jl#482
For consistency, now all errors encountered during
start()
are just sent as warning and only thrown when callingsave_payload
.This should not break precompilation of PlotlyJS but the actual error message will not be thrown in
PlotlyJS
as a customsavefig
implementation is used (which does not callPlotlyKaleido.savefig
)