substitute old savefig code with PlotlyKaleido

[BeastyBlacksmith]

No description provided.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.07%. Comparing base (457befe) to head (7481ad7).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/PlotlyJS.jl	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   35.62%   28.07%   -7.55%     
==========================================
  Files           8        8              
  Lines         306      260      -46     
==========================================
- Hits          109       73      -36     
+ Misses        197      187      -10     

Flag	Coverage Δ
unittests	28.07% <75.00%> (-7.55%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thchr]

Would this fix #473? Seems Windows still hangs on precompilation :(

[BeastyBlacksmith]

Well, it doesn't hang on precompilation, but errors at using time

[thchr]

For extensions that pull in PlotlyJS.jl, this seems to be essentially an equivalent problem though?

[BeastyBlacksmith]

In that it doesn't work on windows, yes.

[disberd]

@BeastyBlacksmith, is there a reason why this PR didn't use savefig directly from PlotlyKaleido instead of basically reimplementing the same method?

I had a quick look at the code here and didn't see too much difference.

Edit: I see that it might be due to the html show part... though it's a pity to have the duplication

[BeastyBlacksmith]

though it's a pity to have the duplication

Yeah, they differed slightly, so I didn't want to touch it. But if you have a way to streamline that, feel free to go for it.