Skip to content

Commit 75f43fa

Browse files
committed
TracyProfiler: Use rr-safe nopl; rdtsc sequence
Several users have reported masssive slowdowns to rr record/replay in packages that have the tracy client loaded. The issue turns out to be an unlucky false positive in an rr heuristic that determines the patchability of `rdtsc`. In rr master, it is possible to guarantee patchability by using a specific `nopl; rdtsc` sequence. Add a patch to tracy to do just that. See also rr-debugger/rr#3580 JuliaLang/julia#50975
1 parent e8a69fe commit 75f43fa

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

T/TracyProfiler/build_tarballs.jl

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ fi
4444
atomic_patch -p1 ../patches/TracyProfiler-nfd-extended-1.0.2.patch
4545
atomic_patch -p1 ../patches/TracyProfiler-filter-user-text.patch
4646
atomic_patch -p1 ../patches/TracyProfiler-no-divide-zero.patch
47+
atomic_patch -p1 ../patches/TracyProfiler-rr-nopl-seq.patch
4748
4849
# Build / install the profiler GUI
4950
make -e -j${nproc} -C profiler/build/unix LEGACY=1 IMAGE=tracy release
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
commit 1491e5d708b611d4e592e3d896960983825d1a90
2+
Merge: 84eff4b0 e1b1fd72
3+
Author: Bartosz Taudul <[email protected]>
4+
Date: Thu Aug 17 14:58:30 2023 +0200
5+
6+
Merge pull request #595 from bjornblissing/master
7+
8+
Wrap std::numeric_limits<T>::max() in parenthesis
9+

0 commit comments

Comments
 (0)