Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash(T(Inf)) broken with current Julia master #141

Closed
jmkuhn opened this issue Sep 28, 2020 · 7 comments
Closed

hash(T(Inf)) broken with current Julia master #141

jmkuhn opened this issue Sep 28, 2020 · 7 comments

Comments

@jmkuhn
Copy link
Contributor

jmkuhn commented Sep 28, 2020

julia> versioninfo()
Julia Version 1.6.0-DEV.1066
Commit b89c4a3cb5 (2020-09-28 08:12 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin18.7.0)
  CPU: Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-10.0.1 (ORCJIT, skylake)

julia> hash(d32"Inf")
0x0000000000000001

julia> hash(Inf)
0x807bb202c9cbfc6f
@stevengj
Copy link
Member

Is this a bug in DecFP, or in Julia? It works in 1.5.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Sep 28, 2020

I think this is due to a change in Julia. I run the DecFP tests vs Julia master about once per week. Due to issue JuliaPackaging/BinaryBuilder.jl#913 is has been a couple weeks since I ran the tests, but this is the first time I've seen this failure. I haven't had time yet to investigate what has changed.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Sep 28, 2020

Heisenbug - when run in the VSCode debugger, hash(d32"Inf") == 0x807bb202c9cbfc6f.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Sep 29, 2020

git bisect indicates the first bad commit is JuliaLang/julia@9adcdd4.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Sep 29, 2020

This is a Julia/LLVM bug. I have isolated a case that doesn't use DecFP. I'll write and submit a Julia issue in the morning.

Edit:
JuliaLang/julia#37800

@stevengj
Copy link
Member

stevengj commented Oct 1, 2020

Thanks for tracking this down.

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Oct 30, 2020

Fixed by JuliaLang/julia#38031

@jmkuhn jmkuhn closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants