Generate Windows import library for with major version only #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/win-implib
branch
from
c99a21c to
cad8804
Compare
|
@staticfloat bump |
|
Looks like this wasn't enough: JuliaLang/julia#47676 (comment). Edit: in particular, the import library mentions only sandbox:/tmp/tmp.gOMgDE/lib # strings libblastrampoline-5.dll.a | grep 'libblastrampoline-5'
libblastrampoline-5-2-0.dll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested (also because to test this I'd need to build a library linked to the new build of lbt), but I'm moderately confident this should solve #87, but as a side effect it'll break the ABI of the Windows library. In addition we could remove
LIB_FULL_VERSIONfor Windows, but that'd require more conditionals, I'm not sure this is worth the added complexity if we can fix the issue by adjusting the argument ofIMPLIB_FLAGS.Going forward, maintainers of lbt must remember to keep the soversion in
src/Make.incwith the version of number of the package.