Skip to content

Retry when juliaup add hits permission denied on rename #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 2 commits into from
Jan 17, 2026
+45 −3
Merged

Retry when juliaup add hits permission denied on rename #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7fe4d0
Retry when `juliaup add` hits permission denied on rename
visr Jan 6, 2026
b757e3d
Merge branch 'main' into retries
IanButterworth Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ path-absolutize = "3"
numeric-sort = "0.1"
regex = "1"
toml = "0.9"
retry = "2"

[target.'cfg(windows)'.dependencies]
windows = { version = "0.62", features = ["Win32_Foundation", "Win32_UI_Shell", "Win32_Security", "Win32_System_JobObjects", "Win32_System_Console", "Win32_System_Threading", "Services_Store", "Foundation", "Foundation_Collections", "Web_Http", "Web_Http_Headers", "Storage_Streams", "Management_Deployment"] }
Expand Down
5 changes: 3 additions & 2 deletions src/operations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use crate::utils::get_bin_dir;
use crate::utils::get_julianightlies_base_url;
use crate::utils::get_juliaserver_base_url;
use crate::utils::is_valid_julia_path;
use crate::utils::retry_rename;
use crate::utils::{print_juliaup_style, JuliaupMessageType};
use anyhow::{anyhow, bail, Context, Error, Result};
use bstr::ByteSlice;
Expand Down Expand Up @@ -676,7 +677,7 @@ pub fn install_from_url(
if target_path.exists() {
std::fs::remove_dir_all(&target_path)?;
}
std::fs::rename(temp_dir.keep(), &target_path)?;
retry_rename(&temp_dir.keep(), &target_path)?;

Ok(JuliaupConfigChannel::DirectDownloadChannel {
path: path.to_string_lossy().into_owned(),
Expand Down Expand Up @@ -1585,7 +1586,7 @@ pub fn update_version_db(channel: &Option<String>, paths: &GlobalPaths) -> Resul
new_config_file.data.last_version_db_update = Some(chrono::Utc::now());

if let Some(temp_versiondb_download_path) = temp_versiondb_download_path {
std::fs::rename(&temp_versiondb_download_path, &paths.versiondb)?;
retry_rename(&temp_versiondb_download_path, &paths.versiondb)?;
} else if delete_old_version_db {
let _ = std::fs::remove_file(&paths.versiondb);
}
Expand Down
32 changes: 31 additions & 1 deletion src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
use anyhow::{anyhow, bail, Context, Result};
use console::style;
use retry::{
delay::{jitter, Fibonacci},
retry, OperationResult,
};
use semver::{BuildMetadata, Version};
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use url::Url;

pub fn get_juliaserver_base_url() -> Result<Url> {
Expand Down Expand Up @@ -223,3 +227,29 @@ pub fn print_juliaup_style(action: &str, message: &str, message_type: JuliaupMes

eprintln!("{} {}", styled_action, message);
}

/// Retry a rename with Fibonacci backoff to handle transient permission errors
/// from e.g. antivirus scanners. Similar approach to rustup.
pub fn retry_rename(src: &Path, dest: &Path) -> Result<()> {
// 20 fib steps from 1 millisecond sums to ~18 seconds
retry(
Fibonacci::from_millis(1).map(jitter).take(20),
|| match std::fs::rename(src, dest) {
Ok(()) => OperationResult::Ok(()),
Err(e) => match e.kind() {
std::io::ErrorKind::PermissionDenied => {
log::debug!("Retrying rename {} to {}.", src.display(), dest.display());
OperationResult::Retry(e)
}
_ => OperationResult::Err(e),
},
},
)
.with_context(|| {
format!(
"Failed to rename '{}' to '{}'.",
src.display(),
dest.display()
)
})
}