-
Notifications
You must be signed in to change notification settings - Fork 104
query to code sign PR builds on mac #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to automatically handle code signing for Julia PR builds on macOS, addressing the issue where PR builds fail to run due to lack of code signing. The feature provides users with a prompt to automatically codesign Julia binaries and libraries after installation.
- Adds interactive codesigning prompt for PR builds on macOS
- Implements automatic codesigning of Julia binary and dylib files
- Provides fallback instructions for manual codesigning if user declines
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Nice. Did you not need to sign the stdlibs? |
|
Nope, Claude said that those had no signature at all while the julia itself and libjulia had a signature that was invalid which caused the crash.. |
|
Ah ok |
|
I guess for unsigned it does the web lookup but for invalid signed it just gives up straight away.. 🤷 |
|
I think adding a test for this would be quite difficult, so confirming it works locally at least. |
Fixes #1127
Fixes #1000
Usage example:
Mostly built with Claude Code 🤖