Skip to content

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Oct 17, 2025

Fixes #1127
Fixes #1000

Usage example:

~/juliaup main*
❯ ./target/debug/juliaup add pr59847   
Installing Julia pr59847-macos-aarch64

WARNING: PR builds are not code-signed for macOS.
The Julia binary will fail to run unless you codesign it locally.

Would you like to automatically codesign this PR build now? [y/N]: y

Codesigning Julia binary...
/Users/kc/.julia/juliaup/julia-pr59847/bin/julia: replacing existing signature
Codesigning Julia library...
/Users/kc/.julia/juliaup/julia-pr59847/lib/libjulia.1.13.0.dylib: replacing existing signature
/Users/kc/.julia/juliaup/julia-pr59847/lib/libjulia.dylib: replacing existing signature
/Users/kc/.julia/juliaup/julia-pr59847/lib/libjulia.1.13.dylib: replacing existing signature
✓ Codesigning completed successfully.

~/juliaup main* 20s
❯ ./target/debug/julia +pr59847        
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.13.0-DEV.1316 (2025-10-16)
 _/ |\__'_|_|_|\__'_|  |  kc/bracket_complete/6f38ab386b4 (fork: 1 commits, 2 days)
|__/                   |

julia> VERSION
v"1.13.0-DEV.1316"

Mostly built with Claude Code 🤖

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to automatically handle code signing for Julia PR builds on macOS, addressing the issue where PR builds fail to run due to lack of code signing. The feature provides users with a prompt to automatically codesign Julia binaries and libraries after installation.

  • Adds interactive codesigning prompt for PR builds on macOS
  • Implements automatic codesigning of Julia binary and dylib files
  • Provides fallback instructions for manual codesigning if user declines

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IanButterworth
Copy link
Member

Nice. Did you not need to sign the stdlibs?

@KristofferC
Copy link
Member Author

Nope, Claude said that those had no signature at all while the julia itself and libjulia had a signature that was invalid which caused the crash..

@IanButterworth
Copy link
Member

Ah ok

@KristofferC
Copy link
Member Author

I guess for unsigned it does the web lookup but for invalid signed it just gives up straight away.. 🤷

@IanButterworth
Copy link
Member

I think adding a test for this would be quite difficult, so confirming it works locally at least.

% ./target/release/juliaup add pr59893

WARNING: Note that unmerged PRs may not have been reviewed for security issues etc.
Review code at https://github.com/JuliaLang/julia/pull/59893

Installing Julia pr59893-macos-aarch64

WARNING: PR builds are not code-signed for macOS.
The Julia binary will fail to run unless you codesign it locally.

Would you like to automatically codesign this PR build now? [Y/n]: 

Codesigning Julia binary...
/Users/ian/.julia/juliaup/julia-pr59893/bin/julia: replacing existing signature
Codesigning Julia library...
/Users/ian/.julia/juliaup/julia-pr59893/lib/libjulia.1.13.0.dylib: replacing existing signature
/Users/ian/.julia/juliaup/julia-pr59893/lib/libjulia.dylib: replacing existing signature
/Users/ian/.julia/juliaup/julia-pr59893/lib/libjulia.1.13.dylib: replacing existing signature
✓ Codesigning completed successfully.
ian@Ians-MacBook-Pro juliaup % ./target/release/julia +pr59893  
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.13.0-DEV.1334 (2025-10-18)
 _/ |\__'_|_|_|\__'_|  |  DilumAluthgeBot:BumpStdlibs/JuliaSyntaxHighlighting-2817dba-master/4997e0a0dc5 (fork: 1 commits, 1 day)
|__/                   |

julia> 

@IanButterworth IanButterworth merged commit 0484ea7 into JuliaLang:main Oct 19, 2025
28 checks passed
@IanButterworth IanButterworth mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On macOS, when a PR build is installed, Juliaup should print instructions for doing the ad-hoc codesigning Warn user and get opt-in for +pr mode

3 participants