Don't orphan old julia versions when failing to delete them. #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidanthoff
approved these changes
Jul 21, 2025
Collaborator
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1146 fixes #1153
only remove a version from the installed version database if we successfully deleted them.
When failing to remove a version, at least on windows, it is most likely that that version is still running somewhere.
Added a bit of text to hint at that possibility.
With this change
juliaup gcworks as intended after that message.regarding #1146: it might still be useful to have orphan pruning capabilities as a fallback, but i've opted to keep the two PRs separate for easier review and merging