Skip to content

inference: Make test indepdent of the Complex method table #59105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025
Merged

inference: Make test indepdent of the Complex method table #59105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Compiler/test/inference.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3549,8 +3549,14 @@ f31974(n::Int) = f31974(1:n)
# call cycles.
@test code_typed(f31974, Tuple{Int}) !== nothing

f_overly_abstract_complex() = Complex(Ref{Number}(1)[])
@test Base.return_types(f_overly_abstract_complex, Tuple{}) == [Complex]
# Issue #33472
struct WrapperWithUnionall33472{T<:Real}
x::T
end

f_overly_abstract33472() = WrapperWithUnionall33472(Base.inferencebarrier(1)::Number)
# Check that this doesn't infer as `WrapperWithUnionall33472{T<:Number}`.
@test Base.return_types(f_overly_abstract33472, Tuple{}) == [WrapperWithUnionall33472]
Copy link
Member

@JeffBezanson JeffBezanson Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it has a decent chance to be inferred as WrapperWithUnionall33472{Int}.

Copy link
Member Author

@Keno Keno Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can write it as inferencebarrier with a type assert, which is the usual pattern. I was mostly just preserving what is already there.


# Issue 26724
const IntRange = AbstractUnitRange{<:Integer}
Expand Down