wip: inference: allow PartialStruct to have Union{} field to indicate strict undef
#57541
+291
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/strict-undef-fields
branch
from
6c81b84 to
f0b8a63
Compare
…strict undef This change allows `PartialStruct` to represent structs with strictly uninitialized fields. Also, this lets us fix the length of `typ::PartialStruct`'s `fields` to always match the number of fields in `typ.typ`. Instead of the current design where the length of `fields` changes depending on the number of initialized fields, it seems simpler to have `PartialStruct`s representing the same `typ` always have the same `fields` length. So, I've included that refactoring as well. - fixes the newly detected error in Oscar.jl
aviatesk
force-pushed
the
avi/strict-undef-fields
branch
from
f0b8a63 to
245049e
Compare
aviatesk
force-pushed
the
avi/strict-undef-fields
branch
from
245049e to
c8dcd2c
Compare
|
The initial choice to make |
serenity4
reviewed
Feb 26, 2025
| fldcnt = fieldcount_noerror(objt)::Int | ||
| fields = Any[fieldtype(objt0, i) for i = 1:fldcnt] | ||
| if fields[fldidx] === Union{} | ||
| return nothing # refine this field |
There was a problem hiding this comment.
I'm not sure I understand the comment here, doesn't refining mean returning a PartialStruct? (though it makes sense to return nothing as a Union{} field type already implies undef[fldidx] === true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
PartialStructto represent structs with strictly uninitialized fields.Also, this lets us fix the length of
typ::PartialStruct'sfieldsto always match the number of fields intyp.typ. Instead of the current design where the length offieldschanges depending on the number of initialized fields, it seems simpler to havePartialStructs representing the sametypalways have the samefieldslength. So, I've included that refactoring as well.Fixes the newly detected error in Oscar.jl.
Remaining TODOs: