Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports release 1.12 #57536

Open
wants to merge 4 commits into
base: release-1.12
Choose a base branch
from
Open

Backports release 1.12 #57536

wants to merge 4 commits into from

Conversation

KristofferC
Copy link
Member

Backported PRs:

Need manual backport:

Non-merged PRs with backport label:

vtjnash and others added 4 commits February 26, 2025 08:45
@vtjnash @KristofferC
build: fix makefile rules and windows path separator used in build (#…
bec9235 
…57472)

Closes #45262

(cherry picked from commit e026aff)
@vtjnash @KristofferC
strip Module filename from metadata (#57499)
d3499d0 
Fix #57358

(cherry picked from commit 88aa27f)
@PatrickHaecker @KristofferC
Base.summarysize for Memory with Union (#57508)
b565c28 
Fixes the double accounting of the union byte array in
`Base.summarysize` as described in #57506.

If this is the correct fix, can it be backported to 1.11?

Fix #57506

(cherry picked from commit 7b7ba33)
@nsajko @KristofferC
don't mutate globals when constructing Rational from `AbstractIrrat…
d04631d 
…ional` (#55853)

Relying on `ScopedValues`, set `BigFloat` precision without mutating the
global default, while constructing `Rational` from `AbstractIrrational`.

Also helps avoid reading the global defaults for the precision and
rounding mode, together with #56095.

What does this fix:
* in the case of the `Irrational` constants defined in `MathConstants`:
relevant methods have `@assume_effects :foldable` applied, which
includes `:effect_free`, which requires that no globals be mutated
(followup on #55886)
* in the case of `AbstractIrrational` values in general, this PR
prevents data races on the global `BigFloat` precision

(cherry picked from commit 2a89f71)
@KristofferC KristofferC added the release Release management and versioning. label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KristofferC @vtjnash @PatrickHaecker @nsajko