REPL completions: Enter import mode only when cursor beyond "import" #57473
+37
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xal-0
force-pushed
the
repl-autocomplete-fixes
branch
from
a2096b0 to
bd0f54c
Compare
vtjnash
reviewed
Feb 19, 2025
xal-0
added
REPL
xal-0
force-pushed
the
repl-autocomplete-fixes
branch
from
6349257 to
a5113be
Compare
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
force-pushed
the
repl-autocomplete-fixes
branch
from
a5113be to
6c59474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a position argument to
get_import_mode.Fixes #55842