-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the user explicitly asked for 1 thread don't add an interactive one. #57454
base: master
Are you sure you want to change the base?
Conversation
This basically makes the assumption that if the user asked for 1 thread they really want their program to not have threads
As this introduces a complexity to the setting, I think this need the docs to be updated to understand how clear this would be i.e. both |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, just needs a test alongside the ones that check threadpool sizes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sort of thing seems very unintuitive. Why are we getting hidden unexplained threads at all when the user didn't ask for them?
Because the default number of interactive threads changed. See motivation in #57087 From discussion in the multithreading call there was general agreement that while this is complication of a simple rule,
|
This basically makes the assumption that if the user asked for 1 thread they really want their program to not have threads