Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Threads.Condition public #56503

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Make Threads.Condition public #56503

merged 2 commits into from
Nov 28, 2024

Conversation

jakobnissen
Copy link
Contributor

This is documented in the Julia documentation and should have been marked public.

@jakobnissen jakobnissen added the docs This change adds or pertains to documentation label Nov 8, 2024
@jakobnissen
Copy link
Contributor Author

Cai failure looks to be unrelated

@gbaraldi
Copy link
Member

I'm fine with this but I would say that Base.Condition should either be deprecated or straight up replaced with Threads.Condition.

@jakobnissen jakobnissen added the merge me PR is reviewed. Merge when all tests are passing label Nov 12, 2024
@DilumAluthge DilumAluthge requested review from gbaraldi and removed request for gbaraldi November 20, 2024 22:58
@IanButterworth IanButterworth merged commit e50f1ce into JuliaLang:master Nov 28, 2024
7 checks passed
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaraldi gbaraldi Awaiting requested review from gbaraldi

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakobnissen @gbaraldi @giordano @IanButterworth @DilumAluthge