Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channels: fix memory ordering violation in iterate #52407

Merged
merged 1 commit into from
Dec 6, 2023
Merged

channels: fix memory ordering violation in iterate #52407

merged 1 commit into from
Dec 6, 2023

Commits on Dec 5, 2023

  1. channels: fix memory ordering violation in iterate 

    Channel `iterate` calls might miss trailing items without this patch. I
have not seen proof of this reaching a failure, but we do appear to be
missing this ordering specification in visual review.

Should not make a difference to generated code on x86, which already has
TSO guaranteed, but may alter optimizations and other CPUs with weaker
memory orderings.
    @vtjnash
    vtjnash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8d961c4 View commit details
    Browse the repository at this point in the history