update TOML from upstream library #47448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/toml_update
branch
from
b441f7f to
9f80d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the TOML library is split between Base and the stdlib because the parser is needed in Base for package loading. Development typically tends to happen in https://github.com/JuliaLang/TOML.jl though. As @DilumAluthge have suggested, we should probably archive the external repo and make all TOML work in the Julia repo since splitting the development into two places is error prone.
The main thing this PR does is to change the testing from checking in the test files to using an external repo to download the test files from. This significantly reduces the number of test files we ship with Julia. There are also some small bug fixes in there.
Closes #46454